go/worker/compute/executor: Minor fixes #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/bugfix/minor-fixes
branch
3 times, most recently
from
6bee867 to
3d36519
Compare
Codecov Report
@@ Coverage Diff @@
## master #5426 +/- ##
==========================================
+ Coverage 66.41% 66.42% +0.01%
==========================================
Files 533 533
Lines 56351 56364 +13
==========================================
+ Hits 37424 37442 +18
- Misses 14513 14519 +6
+ Partials 4414 4403 -11
|
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
Nov 6, 2023
peternose
force-pushed
the
peternose/bugfix/minor-fixes
branch
from
3d36519 to
62ebb4e
Compare
kostko
approved these changes
Nov 7, 2023
The periodic re-attestation happens every hour, while explicitly requested re-attestation takes place approximately every 1 to 2 hours. This results in both re-attestations occurring closely together. To avoid unnecessary re-attestation and re-registration, we extend the periodic re-attestation interval to encompass the worst-case scenario of explicit attestation.
When a node is not a member of the committee, events, commitments, and transactions accumulate in the channels. When the node gets re-elected, it must process these channels first, potentially resulting in delayed submission of its commitments or incorrect discrepancy detection.
peternose
force-pushed
the
peternose/bugfix/minor-fixes
branch
from
62ebb4e to
626172d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.