Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: don't push down some conditions to projections #37992

Merged
merged 7 commits into from
Sep 26, 2022
Merged

planner: don't push down some conditions to projections #37992

merged 7 commits into from
Sep 26, 2022

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Sep 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number:

Problem Summary:
Some conditions shouldn't be pushed down to projection.

What is changed and how it works?

Check whether the conditions can be pushed down to projection.

There may be some side effect, see the knowledge base doc for more details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Reminiscent Reminiscent added the sig/planner SIG: Planner label Sep 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2022
AilinKid
AilinKid reviewed Sep 21, 2022
View reviewed changes
expression/util.go Outdated
// e.g. CREATE TABLE t3(c0 INT, primary key(c0));
// SELECT v2.c0 FROM (select 1 as c0 from t3) v2 WHERE (v2.c0)like(True);
// The cond `(v2.c0)like(True)` can not be substituted when the new collation enable. So we shouldn't push the cond down to the projection.
func ColumnSubstitute4PPD2P(expr Expression, schema *Schema, newExprs []Expression) (bool, Expression) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the func name is complicated >.<

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5f3e441

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@Reminiscent
Copy link
Contributor Author

/run-mysql-test tide-test=pr/1979

@Reminiscent
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2022
@Reminiscent Reminiscent removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@Reminiscent
Copy link
Contributor Author

/run-mysql-test tide-test=pr/1979

@Reminiscent
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1979

@Reminiscent
Copy link
Contributor Author

/run-check_dev_2

@Reminiscent Reminiscent removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@Reminiscent
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1979

@Reminiscent Reminiscent added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 23, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@Reminiscent
Copy link
Contributor Author

/run-mysql-test tidb-test=pr/1979

@ti-chi-bot ti-chi-bot merged commit 7e8d558 into pingcap:master Sep 26, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 26, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2022
@Reminiscent @ti-srebot
cherry pick pingcap#37992 to release-6.1
470c461 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #38159

@ti-srebot ti-srebot mentioned this pull request Sep 26, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 26, 2022
@Reminiscent @ti-srebot
cherry pick pingcap#37992 to release-6.3
cfbb44f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.3 in PR #38160

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [4] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 4, success 13, total 17 19 min New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 3, success 8, total 11 8 min 11 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 2, success 26, total 28 7 min 11 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 5 min 2 sec New failing
idc-jenkins-ci/integration-cdc-test ✅ all 37 tests passed 26 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 23 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 5 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 5 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Reminiscent Reminiscent deleted the issue35623 branch September 26, 2022 08:02
Reminiscent added a commit to Reminiscent/tidb that referenced this pull request Oct 21, 2022
@Reminiscent
planner: don't push down some conditions to projections (pingcap#37992)
f5de988 
close pingcap#35623
@Reminiscent Reminiscent mentioned this pull request Oct 21, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Oct 21, 2022
@Reminiscent
planner: don't push down some conditions to projections (#37992) (#38596
e8eeccc 
)

ref #35623
@Reminiscent
Copy link
Contributor Author

THE pr #38802 handle the same problem but in a more reasonable way. So we don't need this PR because that PR has changed the code of this PR.

@qw4990 qw4990 mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@AilinKid AilinKid AilinKid approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Reminiscent @ti-chi-bot @ti-srebot @sre-bot @AilinKid @xuyifangreeneyes