Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: don't push down some conditions to projections (#37992) #38159

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 26, 2022

cherry-pick #37992 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/38159

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/38159:release-6.1-7e8d55818fa9

What problem does this PR solve?

Issue Number: close #35623
close #37971

Problem Summary:
Some conditions shouldn't be pushed down to projection.

What is changed and how it works?

Check whether the conditions can be pushed down to projection.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 26, 2022
@ti-srebot ti-srebot added sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick labels Sep 26, 2022
@ti-srebot ti-srebot added this to the v6.1.1 milestone Sep 26, 2022
@ti-srebot
Copy link
Contributor Author

@Reminiscent you're already a collaborator in bot's repo.

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 31, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2022
@ti-chi-bot
Copy link
Member

@ti-srebot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Reminiscent
Copy link
Contributor

#38838 is a improved pr based on the current PR. It's already been merged, so close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants