cleanup declaration of ModelInterface's SharedPtrs #33
+5
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2016
sloretz
reviewed
Dec 18, 2017
There was a problem hiding this comment.
Looks like a good change to me.
@scpeters is ros:0.4 the right branch for this? The removal of the type ModelInterfaceSharedPtr from urdf_world/types.h and removal of #include "urdf_model/model.h" from urdf_world/world.h looks like potentially breaking changes if 0.4 has already been released.
rhaschke
force-pushed
the
cleanup-modelinterface-declaration
branch
from
f3a88a2
to
c1d1f66
Compare
|
I'm going through my open PRs and just found this 6-years old one, which was already kind-of approved by @sloretz. |
rhaschke
added a commit
to ubi-agni/urdfdom
that referenced
this pull request
Sep 22, 2022
rhaschke
added a commit
to ubi-agni/urdf
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to declare the
SharedPtrsforModelInterfacetogether with all other model-related types inurdf_model/types.hinstead ofurdf_world/types.h.Currently, even after having included
urdf_model/model.h, one also needs to includeurdf_world/types.hto get the related SharedPtr definitions.With this PR, it suffices to include
urdf_model/types.hto get all declarations or to includeurdf_model/model.hfor all declarations and definition ofModelInterface.