-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockifier): resource cost ratio type changed to u64 ratio from u128 ratio #1174
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
- Coverage 74.18% 71.06% -3.13%
==========================================
Files 359 86 -273
Lines 36240 11491 -24749
Branches 36240 11491 -24749
==========================================
- Hits 26886 8166 -18720
+ Misses 7220 2957 -4263
+ Partials 2134 368 -1766
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d32a194
to
1289853
Compare
7441965
to
b741627
Compare
1289853
to
2ad639a
Compare
b741627
to
8a7bb3b
Compare
2ad639a
to
fd9d729
Compare
8a7bb3b
to
5dae256
Compare
fd9d729
to
74c50d6
Compare
5dae256
to
72730ea
Compare
74c50d6
to
76ec0e3
Compare
72730ea
to
893e4f1
Compare
76ec0e3
to
f67b6be
Compare
893e4f1
to
96cb7e1
Compare
f67b6be
to
6f1a5fb
Compare
96cb7e1
to
8dec550
Compare
a877b2b
to
455529c
Compare
8dec550
to
372659d
Compare
455529c
to
f28fdce
Compare
372659d
to
123d82e
Compare
f28fdce
to
fe58aee
Compare
123d82e
to
ec9d68f
Compare
fe58aee
to
9b4d1d0
Compare
ec9d68f
to
63552c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
crates/blockifier/src/test_utils.rs
line 387 at r1 (raw file):
pub fn u64_from_usize(val: usize) -> u64 { val.try_into().unwrap() }
this is no longer a test util
Code quote:
pub fn u64_from_usize(val: usize) -> u64 {
val.try_into().unwrap()
}
9b4d1d0
to
26aa095
Compare
63552c1
to
d3e8b3f
Compare
26aa095
to
3c2d2d7
Compare
d3e8b3f
to
ff01543
Compare
3c2d2d7
to
7b32ee0
Compare
ff01543
to
a51fb1d
Compare
a51fb1d
to
ccb64a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
This change is