feat(blockifier): panic on GasVector arithmetic overflow

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): panic or saturate GasAmount arithmetic depending on 'natural' source of values #1281
• feat(blockifier): panic on GasVector arithmetic overflow #1280 👈
• feat(blockifier): panic or saturate Fee arithmetic depending on 'natural' source of values #1268
• feat(blockifier): safe addition of fee amounts in business logic #1255
• feat(blockifier): event fields converted from u128 to u64 #1250
• feat(starknet_api): resource bounds struct now has typed fields #1180
• refactor(blockifier,starknet_api): migrate GasVector from blockifier to starknet_api #1179
• refactor(blockifier): refactor to_discounted_l1_gas #1178
• refactor(blockifier): indirection in GasPrices struct #1177
• refactor(starknet_api): gas vector to contain fields of type GasAmount #1176
• refactor(blockifier,starknet_api): gas amount is now a u64, not a u128 #1175
• refactor(blockifier): resource cost ratio type changed to u64 ratio from u128 ratio #1174
• feat(blockifier, starknet_api): add explcit typing and arithmetic to gas amount/price, and fee #1173
• refactor(blockifier,starknet_api): add GasAmount (u128) type and use in blockifier's GasVector #1172
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.883 ms 34.934 ms 34.991 ms]
change: [-3.5495% -2.2480% -1.1386%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severe

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.871 ms 29.987 ms 30.123 ms]
change: [-3.1067% -2.0762% -1.1562%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
4 (4.00%) high mild
8 (8.00%) high severe

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 35 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (b0cfe82) to head (f291432).
Report is 341 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/fee/resources.rs	61.53%	16 Missing and 4 partials ⚠️
crates/blockifier/src/fee/gas_usage.rs	55.00%	7 Missing and 2 partials ⚠️
crates/starknet_api/src/execution_resources.rs	66.66%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
+ Coverage   74.18%   81.17%   +6.98%     
==========================================
  Files         359       93     -266     
  Lines       36240    12508   -23732     
  Branches    36240    12508   -23732     
==========================================
- Hits        26886    10153   -16733     
+ Misses       7220     1906    -5314     
+ Partials     2134      449    -1685     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yoni-Starkware]

Reviewed 2 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/fee/resources.rs line 310 at r2 (raw file):

                    "Message resources to starknet gas cost overflowed: tried to add \
                     {accumulator:?} to {cost:?}"
                )

Does rust have something like checked_sum?

Code quote:

        .iter()
        .fold(GasVector::ZERO, |accumulator, cost| {
            accumulator.checked_add(*cost).unwrap_or_else(|| {
                panic!(
                    "Message resources to starknet gas cost overflowed: tried to add \
                     {accumulator:?} to {cost:?}"
                )

[dorimedini-starkware]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/src/fee/resources.rs line 310 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Does rust have something like checked_sum?

1. I didn't find something I liked; there is nothing built in
2. what would the panic message look like?

[Yoni-Starkware]

Reviewed 2 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/fee/resources.rs line 310 at r2 (raw file):

Previously, dorimedini-starkware wrote…

1. I didn't find something I liked; there is nothing built in
2. what would the panic message look like?

I want to save some code duplication with all those panics. Not in this PR though

[dorimedini-starkware]

Merge activity

• Oct 14, 3:01 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Oct 14, 3:02 AM EDT: A user merged this pull request with Graphite.