refactor(starknet_api): gas vector to contain fields of type GasAmount

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): panic or saturate GasAmount arithmetic depending on 'natural' source of values #1281
• feat(blockifier): panic on GasVector arithmetic overflow #1280
• feat(blockifier): panic or saturate Fee arithmetic depending on 'natural' source of values #1268
• feat(blockifier): safe addition of fee amounts in business logic #1255
• feat(blockifier): event fields converted from u128 to u64 #1250
• feat(starknet_api): resource bounds struct now has typed fields #1180
• refactor(blockifier,starknet_api): migrate GasVector from blockifier to starknet_api #1179
• refactor(blockifier): refactor to_discounted_l1_gas #1178
• refactor(blockifier): indirection in GasPrices struct #1177
• refactor(starknet_api): gas vector to contain fields of type GasAmount #1176 👈
• refactor(blockifier,starknet_api): gas amount is now a u64, not a u128 #1175
• refactor(blockifier): resource cost ratio type changed to u64 ratio from u128 ratio #1174
• feat(blockifier, starknet_api): add explcit typing and arithmetic to gas amount/price, and fee #1173
• refactor(blockifier,starknet_api): add GasAmount (u128) type and use in blockifier's GasVector #1172
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.06%. Comparing base (b0cfe82) to head (5419ddc).
Report is 280 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (5419ddc). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (5419ddc)
	3	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1176       +/-   ##
===========================================
- Coverage   74.18%   58.06%   -16.13%     
===========================================
  Files         359      178      -181     
  Lines       36240    23780    -12460     
  Branches    36240    23780    -12460     
===========================================
- Hits        26886    13807    -13079     
- Misses       7220     8466     +1246     
+ Partials     2134     1507      -627     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.581 ms 34.619 ms 34.664 ms]
change: [-6.6950% -4.9732% -3.3227%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severe

[dorimedini-starkware]

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

---

crates/papyrus_storage/src/serialization/serializers.rs line 0 at r1 (raw file):
@ShahakShama would this change break backwards-compatibility?
@Yoni-Starkware do we care?

[github-actions]

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [29.695 ms 29.739 ms 29.786 ms]
change: [+1.2308% +1.4363% +1.6346%] (p = 0.00 < 0.05)
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.533 ms 34.563 ms 34.600 ms]
change: [-3.9525% -2.5671% -1.3779%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe

[Yoni-Starkware]

Reviewed 6 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 8 of 9 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @ShahakShama)

---

crates/papyrus_storage/src/serialization/serializers.rs line at r1 (raw file):

Previously, dorimedini-starkware wrote…

@ShahakShama would this change break backwards-compatibility?
@Yoni-Starkware do we care?

We (SN) don't care

---

crates/papyrus_storage/src/serialization/serializers.rs line 295 at r2 (raw file):

        pub l1_gas: GasAmount,
        pub l1_data_gas: GasAmount,
        pub l2_gas: GasAmount,

Why this is duplicated?

Code quote:

    pub struct GasAmount(pub u64);
    pub struct GasPricePerToken {
        pub price_in_fri: GasPrice,
        pub price_in_wei: GasPrice,
    }
    pub struct GasVector {
        pub l1_gas: GasAmount,
        pub l1_data_gas: GasAmount,
        pub l2_gas: GasAmount,

[dorimedini-starkware]

Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @ShahakShama and @Yoni-Starkware)

---

crates/papyrus_storage/src/serialization/serializers.rs line 295 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why this is duplicated?

one in auto_impl_get_test_instance! macro and one in auto_storage_serde! macro

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.948 ms 35.376 ms 35.895 ms]
change: [+1.0680% +2.3904% +3.8509%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severe

[dorimedini-starkware]

Reviewed 1 of 9 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.544 ms 34.608 ms 34.676 ms]
change: [-6.1486% -4.0064% -2.0478%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

[Yoni-Starkware]

Reviewed 1 of 9 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[dorimedini-starkware]

Merge activity

• Oct 9, 6:06 AM EDT: @dorimedini-starkware started a stack merge that includes this pull request via Graphite.
• Oct 9, 6:07 AM EDT: @dorimedini-starkware merged this pull request with Graphite.