chore(blockifier): fetch compiler repo version

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): recompile Cairo1 in the CI #197
• chore(blockifier): add is_legacy method #196
• chore(blockifier): add text file with current compiler version for CI use #195
• chore(blockifier): verify local cairo repo state before compiling #194
• feat(blockifier): support Cairo1 local recompilation #184
• chore(blockifier): verify cairo compiler repo (with correct tag) #183
• feat(blockifier): verify cairo-lang version before Cairo0 compilation #182
• chore(blockifier): fetch compiler repo version #181 👈
• chore(blockifier): move contract compilation logic to separate module + contracts.rs #180
• chore(blockifier): refactor feature contract path getters for different paths #179
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (07-29-chore_blockifier_move_contract_compilation_logic_to_separate_module_contracts.rs@7d376aa). Learn more about missing BASE report.

Files	Patch %	Lines
crates/blockifier/src/test_utils/cairo_compile.rs	0.00%	9 Missing ⚠️

Additional details and impacted files

@@                                                    Coverage Diff                                                    @@
##             07-29-chore_blockifier_move_contract_compilation_logic_to_separate_module_contracts.rs     #181   +/-   ##
=========================================================================================================================
  Coverage                                                                                          ?   76.43%           
=========================================================================================================================
  Files                                                                                             ?      330           
  Lines                                                                                             ?    35011           
  Branches                                                                                          ?    35011           
=========================================================================================================================
  Hits                                                                                              ?    26762           
  Misses                                                                                            ?     5956           
  Partials                                                                                          ?     2293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aner-starkware]

Waiting on discussion about reading the cairo-lang-casm version.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)

[TzahiTaub]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @noaov1)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 47 at r3 (raw file):

#[cached]
/// Returns the version of the Cairo1 compiler* defined in the root Cargo.toml.
pub fn cairo1_compiler_version() -> String {

Add a bash script to read the version from the toml for the CI, and add an assert that the bash output equals the value returned here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.329 ms 66.799 ms 67.534 ms]
change: [-8.3322% -4.5771% -1.3049%] (p = 0.01 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.295 ms 66.790 ms 67.583 ms]
change: [-7.9473% -4.5729% -1.4769%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.972 ms 66.509 ms 67.290 ms]
change: [-9.7916% -6.3802% -3.3682%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

[TzahiTaub]

Reviewed 1 of 4 files at r1, 1 of 3 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @noaov1)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 20 at r6 (raw file):

/// """
/// where `VERSION` can be a simple "x.y.z" version string or an object with a "version" field.
#[derive(Debug, Serialize, Deserialize)]

I think

Suggestion:

/// where `VERSION` can be a simple "x.y.z" version string or an object with a "version" field.

#[derive(Debug, Serialize, Deserialize)]

---

crates/blockifier/src/test_utils/cairo_compile.rs line 46 at r6 (raw file):

#[cached]
/// Returns the version of the Cairo1 compiler* defined in the root Cargo.toml.

why the *? If it's a reference to the head of the file, it isn't clear (replace with Cairo1 compiler "defined" (see doc at the head of the file) in the root... or something).

Code quote:

compiler* defined 

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, @noaov1, and @TzahiTaub)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 20 at r6 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

I think

this is not a docstring for the whole file, just for the struct(s) parsing the toml

---

crates/blockifier/src/test_utils/cairo_compile.rs line 46 at r6 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

why the *? If it's a reference to the head of the file, it isn't clear (replace with Cairo1 compiler "defined" (see doc at the head of the file) in the root... or something).

better?

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.719 ms 64.820 ms 64.947 ms]
change: [-10.406% -7.2346% -4.4548%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe

[TzahiTaub]

Reviewed 4 of 4 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 20 at r6 (raw file):

Previously, dorimedini-starkware wrote…

this is not a docstring for the whole file, just for the struct(s) parsing the toml

Just makes it look as docs for the first struct IMO ATM

---

crates/blockifier/src/test_utils/cairo_compile.rs line 46 at r6 (raw file):

Previously, dorimedini-starkware wrote…

better?

Yep

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 20 at r6 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Just makes it look as docs for the first struct IMO ATM

future PRs will add more to this module, this shouldn't be a module docstring.
want me to split the cairo-version-parsing stuff to a separate module and have this as a module-docstirng?

[TzahiTaub]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 20 at r6 (raw file):

Previously, dorimedini-starkware wrote…

future PRs will add more to this module, this shouldn't be a module docstring.
want me to split the cairo-version-parsing stuff to a separate module and have this as a module-docstirng?

No need.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.141 ms 65.431 ms 65.963 ms]
change: [-4.2926% -2.8777% -1.4050%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

[TzahiTaub]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @noaov1)

[dorimedini-starkware]

Merge activity

• Aug 11, 11:28 AM EDT: @dorimedini-starkware started a stack merge that includes this pull request via Graphite.
• Aug 11, 11:41 AM EDT: Graphite rebased this pull request as part of a merge.
• Aug 11, 11:51 AM EDT: @dorimedini-starkware merged this pull request with Graphite.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.613 ms 64.687 ms 64.775 ms]
change: [-10.369% -6.9669% -3.9267%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe