Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blockifier): add is_legacy method #196

Merged
merged 1 commit into from
Aug 11, 2024
Merged

chore(blockifier): add is_legacy method #196

merged 1 commit into from
Aug 11, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jul 30, 2024 •
edited by roi-amaler-starkware
Loading

This change is Reviewable

This was referenced Jul 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Jul 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite Graphite

@dorimedini-starkware dorimedini-starkware mentioned this pull request Jul 30, 2024
Merged
@dorimedini-starkware dorimedini-starkware self-assigned this Jul 30, 2024
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 2618e0f to e073a68 Compare July 30, 2024 13:21
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 9a950bf to 25de71b Compare July 30, 2024 13:22
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from e073a68 to 0cc6a4f Compare July 31, 2024 16:34
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 25de71b to ca8d23b Compare July 31, 2024 16:34
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 0cc6a4f to f400d64 Compare July 31, 2024 16:42
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from ca8d23b to 6799aa3 Compare July 31, 2024 16:42
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from f400d64 to 58aca6d Compare July 31, 2024 16:52
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 6799aa3 to dd8634f Compare July 31, 2024 16:52
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 58aca6d to 7b79e6f Compare July 31, 2024 16:54
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from dd8634f to 9782b30 Compare July 31, 2024 16:54
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 7b79e6f to 738d7f2 Compare August 1, 2024 08:50
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 9782b30 to e6f7a3f Compare August 1, 2024 08:50
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 738d7f2 to 8ea764d Compare August 1, 2024 08:53
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from e6f7a3f to af5515a Compare August 1, 2024 08:53
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 8ea764d to bff65e3 Compare August 1, 2024 09:16
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 8ad0c34 to 1f6f2aa Compare August 5, 2024 13:00
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 08a4c7a to 95021fd Compare August 5, 2024 13:00
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 1f6f2aa to e11a98a Compare August 6, 2024 12:16
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 95021fd to 937e925 Compare August 6, 2024 12:16
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from e11a98a to 4b6aa3d Compare August 6, 2024 13:30
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 937e925 to a84c71c Compare August 6, 2024 13:30
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 4b6aa3d to ae71e03 Compare August 7, 2024 07:00
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from a84c71c to 50c9e51 Compare August 7, 2024 07:00
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from ae71e03 to 3fd07d1 Compare August 7, 2024 14:52
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 50c9e51 to 41e13e2 Compare August 7, 2024 14:52
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 3fd07d1 to 07ec736 Compare August 7, 2024 16:17
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 41e13e2 to 5d3dbb0 Compare August 7, 2024 16:17
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review August 8, 2024 09:51
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 07ec736 to f623af9 Compare August 11, 2024 07:45
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 5d3dbb0 to afc8510 Compare August 11, 2024 07:45
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from f623af9 to 1b9c871 Compare August 11, 2024 08:55
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from afc8510 to e87bd1c Compare August 11, 2024 08:55
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 1b9c871 to 452fc59 Compare August 11, 2024 09:35
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from e87bd1c to 9b0ad2b Compare August 11, 2024 09:35
TzahiTaub
TzahiTaub approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @nimrod-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use branch from 452fc59 to ce6fbbf Compare August 11, 2024 12:58
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 9b0ad2b to 1c94532 Compare August 11, 2024 12:58
TzahiTaub
TzahiTaub approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @nimrod-starkware)

@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Aug 11, 2024 •
edited
Loading

Merge activity

@dorimedini-starkware dorimedini-starkware changed the base branch from 07-30-chore_blockifier_add_text_file_with_current_compiler_version_for_ci_use to graphite-base/196 August 11, 2024 16:33
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/196 to main August 11, 2024 16:40
@dorimedini-starkware dorimedini-starkware force-pushed the 07-30-chore_blockifier_add_is_legacy_method branch from 1c94532 to 67c0d0d Compare August 11, 2024 16:42
@dorimedini-starkware dorimedini-starkware merged commit eb66da4 into main Aug 11, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TzahiTaub TzahiTaub TzahiTaub approved these changes

@AvivYossef-starkware AvivYossef-starkware Awaiting requested review from AvivYossef-starkware

@meship-starkware meship-starkware Awaiting requested review from meship-starkware

@nimrod-starkware nimrod-starkware Awaiting requested review from nimrod-starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorimedini-starkware @TzahiTaub