feat(blockifier): verify cairo-lang version before Cairo0 compilation

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): recompile Cairo1 in the CI #197
• chore(blockifier): add is_legacy method #196
• chore(blockifier): add text file with current compiler version for CI use #195
• chore(blockifier): verify local cairo repo state before compiling #194
• feat(blockifier): support Cairo1 local recompilation #184
• chore(blockifier): verify cairo compiler repo (with correct tag) #183
• feat(blockifier): verify cairo-lang version before Cairo0 compilation #182 👈
• chore(blockifier): fetch compiler repo version #181
• chore(blockifier): move contract compilation logic to separate module + contracts.rs #180
• chore(blockifier): refactor feature contract path getters for different paths #179
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[nimrod-starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @TzahiTaub)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 79 at r1 (raw file):

}

/// Verifies that the required dependencies are available before compiling.

Suggestion:

/// Verifies that the required dependencies are available before compiling; panics if unavailable.

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, @nimrod-starkware, and @TzahiTaub)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 79 at r1 (raw file):

}

/// Verifies that the required dependencies are available before compiling.

Done.

[nimrod-starkware]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @TzahiTaub)

[TzahiTaub]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @meship-starkware)

a discussion (no related file):
What happens ATM if we have the package in the wrong version? We fail the comparison, and if we fix we fix the wrong local version we use (and hopefully fails the CI)

---

---

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

        cairo_lang_version.trim(),
        expected_cairo_lang_version.trim(),
        "cairo-lang not found. Please run:\npip3.9 install -r {}/{}\nthen rerun the test.",

We might have the package in the wrong version

Suggestion:

cairo-lang version {} not found...., expected_cairo_lang_version.trim().rsplit("=").next().unwrap()

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @TzahiTaub)

a discussion (no related file):

Previously, TzahiTaub (Tzahi) wrote…

What happens ATM if we have the package in the wrong version? We fail the comparison, and if we fix we fix the wrong local version we use (and hopefully fails the CI)

The CI installs whatever is in the requirements.txt file, if that version is "wrong" there's nothing we can check

---

---

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

We might have the package in the wrong version

better?

[TzahiTaub]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @meship-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

The CI installs whatever is in the requirements.txt file, if that version is "wrong" there's nothing we can check

I meant if our installed local version doesn't match the requirements file.

---

---

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

Previously, dorimedini-starkware wrote…

better?

Yes, though when the package isn't installed, we'll get (installed version: ) then maybe if cairo_lang_version.is_empty() {"not installed"} else { cairo_lang_version}, and raise the trim()` above as you did for the expected one.

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @meship-starkware)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Yes, though when the package isn't installed, we'll get (installed version: ) then maybe if cairo_lang_version.is_empty() {"not installed"} else { cairo_lang_version}, and raise the trim()` above as you did for the expected one.

* and raise the not a part of the code :)

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

a discussion (no related file):

Previously, TzahiTaub (Tzahi) wrote…

I meant if our installed local version doesn't match the requirements file.

the fix command also compares versions (same cairo0_compile is called), so you will also fail to fix

---

---

crates/blockifier/src/test_utils/cairo_compile.rs line 98 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

* and raise the not a part of the code :)

done. however, can't raise the trim ("value dropped"). defined an intermediate var to call trim once

[TzahiTaub]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

[TzahiTaub]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

[dorimedini-starkware]

Merge activity

• Aug 11, 11:28 AM EDT: @dorimedini-starkware started a stack merge that includes this pull request via Graphite.
• Aug 11, 11:53 AM EDT: Graphite rebased this pull request as part of a merge.
• Aug 11, 12:00 PM EDT: @dorimedini-starkware merged this pull request with Graphite.