chore(blockifier): verify cairo compiler repo (with correct tag)

[dorimedini-starkware]

This change is 

[dorimedini-starkware]

• feat(blockifier): recompile Cairo1 in the CI #197
• chore(blockifier): add is_legacy method #196
• chore(blockifier): add text file with current compiler version for CI use #195
• chore(blockifier): verify local cairo repo state before compiling #194
• feat(blockifier): support Cairo1 local recompilation #184
• chore(blockifier): verify cairo compiler repo (with correct tag) #183 👈
• feat(blockifier): verify cairo-lang version before Cairo0 compilation #182
• chore(blockifier): fetch compiler repo version #181
• chore(blockifier): move contract compilation logic to separate module + contracts.rs #180
• chore(blockifier): refactor feature contract path getters for different paths #179
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on Graphite

[nimrod-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @TzahiTaub)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 68 at r2 (raw file):

}

/// Run a command, assert exit code is zero (otherwise panic with stderr output).

Suggestion:

/// Runs a command. If it has succeeded, it returns the command's output; otherwise, it panics with stderr output.

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, @nimrod-starkware, and @TzahiTaub)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 68 at r2 (raw file):

}

/// Run a command, assert exit code is zero (otherwise panic with stderr output).

Done.

[nimrod-starkware]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @TzahiTaub)

[TzahiTaub]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @nimrod-starkware)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 9 at r3 (raw file):

const CAIRO0_PIP_REQUIREMENTS_FILE: &str = "tests/requirements.txt";
const LOCAL_CAIRO1_REPO_RELATIVE_PATH: &str = "../../../cairo";

This is too strict, please replace with env vars to allow a a hierarchy where the sequencer and cairo dirs aren't siblings, to work.

Code quote:

const LOCAL_CAIRO1_REPO_RELATIVE_PATH: &str = "../../../cairo";

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, @nimrod-starkware, and @TzahiTaub)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 9 at r3 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

This is too strict, please replace with env vars to allow a a hierarchy where the sequencer and cairo dirs aren't siblings, to work.

Done. Now can be overridden by env var

[TzahiTaub]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @meship-starkware)

---

crates/blockifier/src/test_utils/cairo_compile.rs line 62 at r6 (raw file):

/// Returns the path to the local Cairo1 compiler repository.
/// Returns <sequencer_crate_root>/<RELATIVE_PATH_TO_CAIRO_REPO>, where the relative path can be

The Sequencer is not a crate, right?

Suggestion:

<sequencer_repo_root>

[TzahiTaub]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

[dorimedini-starkware]

Merge activity

• Aug 11, 11:28 AM EDT: @dorimedini-starkware started a stack merge that includes this pull request via Graphite.
• Aug 11, 12:02 PM EDT: Graphite rebased this pull request as part of a merge.
• Aug 11, 12:09 PM EDT: @dorimedini-starkware merged this pull request with Graphite.