Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kinetic] Update Travis config to run on Ubuntu 16.04 via Docker. #49

Open
wants to merge 5 commits into
base: kinetic
Choose a base branch
from

Conversation

130s
Copy link
Contributor

@130s 130s commented Oct 7, 2016

@kdhansen Thanks for the comment. The suggested change uses industrial_ci that has a capability to run Kinetic-Xenial on Docker.

Travis CI failing for this PR should be a separate issue (I won't have time to take a deeper look until next weekend, sorry).


UPDATE1. Sorry for much noise. Finally test passed...A lot of commits are squashed and now ready for the review and merge.

To summarize, what this PR does (which has diverted from the original title):

With rgbd launch faces are sometimes detected, so publishtest passes.

@kdhansen
Copy link
Contributor

Travis seems to stop at the Before_script with no further explanation.

@130s
Copy link
Contributor Author

130s commented Feb 15, 2017

Sorry for delay. With industrial_ci much updated since the last run, now it seems to be working, and seems to be detecting something wrong on Xenial-Kinetic.

https://travis-ci.org/wg-perception/people/jobs/202012035#L3204

[ERROR] [1487191552.700384696]: Cascade file /usr/share/opencv/haarcascades/haarcascade_frontalface_alt.xml doesn't exist.

, which I assume prevents roslaunch from running and thus tests fail.

On my Xenial machine, the file in question haarcascade_frontalface_alt.xml is found at the following dir, which is different from what's expected above.

/opt/ros/kinetic/share/OpenCV-3.1.0-dev/haarcascades/haarcascade_frontalface_alt.xml

@130s
Copy link
Contributor Author

130s commented Feb 15, 2017

The issue in the above comment is now successfully worked around by 4daa0af, which isn't a good solution at all though.

Now, still seems that either roslaunch isn't running nor something else is happening.

@mathias-luedtke
Copy link

ecc3dfc introduces invalid XML syntax:

* WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
    <group if="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_withface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="30.0"/>
      <param name="hzerror" value="29.9"/>
    </group>
    
    <param name="topic" value="face_detector/people_tracker_measurements_array"/>
    <param name="test_duration" value="15.0"/>
  </test>

And something is wrong with the target dependencies:

Warnings << people_tracking_filter:cmake /root/catkin_ws/logs/people_tracking_filter/build.cmake.000.log
CMake Warning (dev) at CMakeLists.txt:61 (add_dependencies):
  Policy CMP0046 is not set: Error on non-existent dependency in
  add_dependencies.  Run "cmake --help-policy CMP0046" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.

  The dependency target "people_msgs_gencpp" of target "people_tracker" does
  not exist.
This warning is for project developers.  Use -Wno-dev to suppress it.

Not sure if this fixes the tests..

130s added a commit to 130s/ros_comm that referenced this pull request Feb 16, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in [this PR](wg-perception/people#49):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
130s added a commit to 130s/ros_comm that referenced this pull request Feb 16, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
130s added a commit to 130s/ros_comm that referenced this pull request Feb 16, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
130s added a commit to 130s/ros_comm that referenced this pull request Feb 16, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
130s added a commit to 130s/ros_comm that referenced this pull request Feb 16, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
130s added a commit to 130s/ros_comm that referenced this pull request Feb 16, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
@130s 130s force-pushed the k/update_travis branch 10 times, most recently from d18780c to 4be4152 Compare February 17, 2017 20:09
@130s 130s force-pushed the k/update_travis branch 3 times, most recently from d157761 to b6f9062 Compare February 18, 2017 00:07
@130s
Copy link
Contributor Author

130s commented Feb 18, 2017

Sorry for much noise. Finally test passed...A lot of commits are squashed and now ready for the review and merge.

To summarize, what this PR does (which has diverted from the original title):

With rgbd launch faces are sometimes detected, so publishtest passes.

[face_detector][test common] Fix warning in .launch format.
Fix namespace in testcases.
Increase retry. .bag-based perceptional tests are hard to deterministic, so it makes sense to do this.
Set param use_sim_time.
[face_detector][test] hztest can be used for measureing no publishment. hzerror is not needed in that case.
[face_detector][test] Specify test name. Pass all args.
[face_detector][test] pass_all_args might require all args kept out of include tag.
[face_detector][test] Specify test-name.
[face_detector][test] Disable all tests other than rgbd. I couldn't figure out how to use launches other than face_detector.rgbdlaunch, after hours of trial on local machine. I leave that up to someone else.
[face_detector][test] Detection using rgbd works with this config.
[face_detector][test] Shorter test duration (bag files are less than 7 seconds).
[face_detector][test] Shorter test_duration. We only need a second or so as long as we can confirm the designated topic is being published.
[face_detector][test] rosbag play with clock and loop option.
Since the publish rate of the detected face varies every second because one of the persons in the bag file is moving, [publishtest](http://wiki.ros.org/rostest/Nodes#publishtest) should suit the best in this case.

[face_detector][test common] Enable substitution in rosparam tag.
dirk-thomas pushed a commit to ros/ros_comm that referenced this pull request Feb 18, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
130s added a commit to 130s/ros_comm that referenced this pull request Feb 18, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
@130s
Copy link
Contributor Author

130s commented Feb 28, 2017

Ping any admins. This is ready for review (and merge).

dirk-thomas pushed a commit to ros/ros_comm that referenced this pull request Mar 2, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
@130s
Copy link
Contributor Author

130s commented Mar 27, 2017

Ping any admins. This is ready for review (and merge).

Thanks!

rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017
… confusing.

For example, [this warning msg](https://travis-ci.org/wg-perception/people/jobs/202019288#L3737) (in this [PR](wg-perception/people#49)):

 ```
 * WARN: unrecognized 'group' tag in <node> tag. Node xml is <test name="$(arg testnode_name)" pkg="rostest" test-name="hztest_test" type="hztest">
    <group unless="$(arg expected_success)">
      <node args="-r 0.5 $(find face_detector)/test/face_detector_noface_test_diamondback.bag" name="play" pkg="rosbag" type="play"/>
      <param name="hz" value="0.0"/>
    </group>
```

This is confusing because the tag in question is actually `<test>`, not `<node>`. Although the warning message refers to the exact <test> tag, I didn't try to read it because I was told the issue is with <node>, not <test>.

With this PR the message becomes a bit verbose but hope the readers get better idea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants